Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coins): add p2p feature to mm2_net dependency #2210

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

mariocynicys
Copy link
Collaborator

@mariocynicys mariocynicys commented Sep 3, 2024

so that coins could be compiled (cargo checked, cargo tested) on its own

To Test:
Nothing, this internal KDF PR.

so that coins could be compiled (`cargo check`ed, `cargo test`ed) on its own
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@shamardy shamardy changed the title fix(coins): add p2p feature to mm2_net depedency fix(coins): add p2p feature to mm2_net dependency Sep 5, 2024
@shamardy shamardy merged commit ffed860 into dev Sep 5, 2024
24 of 29 checks passed
@shamardy shamardy deleted the add-p2p-to-coins branch September 5, 2024 00:19
dimxy added a commit to dimxy/komodo-defi-framework that referenced this pull request Sep 13, 2024
* dev:
  chore(RPCs): rename `get_peers_info` RPC to `get_directly_connected_peers` (KomodoPlatform#2195)
  chore(WASM-builds): remove `wasm-opt` overriding (KomodoPlatform#2200)
  fix(coins): add p2p feature to mm2_net dependency (KomodoPlatform#2210)
  chore(test): turn on debug assertion (KomodoPlatform#2204)
  feat(sia): extract sia lib to external repo (KomodoPlatform#2167)
  feat(eth-swap): eth tpu v2 methods, eth docker test enhancements (KomodoPlatform#2169)
  fix(cors): allow OPTIONS request to KDF server (KomodoPlatform#2191)
  docs(README): update commit badges to use dev branch (KomodoPlatform#2193)
  use default value for `komodo_proxy` (KomodoPlatform#2192)
  feat(cosmos): komodo-defi-proxy support (KomodoPlatform#2173)
dimxy added a commit that referenced this pull request Sep 13, 2024
* dev:
  chore(RPCs): rename `get_peers_info` RPC to `get_directly_connected_peers` (#2195)
  chore(WASM-builds): remove `wasm-opt` overriding (#2200)
  fix(coins): add p2p feature to mm2_net dependency (#2210)
  chore(test): turn on debug assertion (#2204)
  feat(sia): extract sia lib to external repo (#2167)
  feat(eth-swap): eth tpu v2 methods, eth docker test enhancements (#2169)
  fix(cors): allow OPTIONS request to KDF server (#2191)
  docs(README): update commit badges to use dev branch (#2193)
  use default value for `komodo_proxy` (#2192)
  feat(cosmos): komodo-defi-proxy support (#2173)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants