Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(Orders): Fix order close button display & change progress system #978

Merged
merged 2 commits into from
Jun 18, 2021
Merged

enhancement(Orders): Fix order close button display & change progress system #978

merged 2 commits into from
Jun 18, 2021

Conversation

ssakone
Copy link

@ssakone ssakone commented Jun 12, 2021

Peek 2021-06-12 13-42

@ssakone ssakone marked this pull request as draft June 12, 2021 13:46
@ssakone ssakone linked an issue Jun 12, 2021 that may be closed by this pull request
[BUG]: Order cancelling button rework #975
Closed
tonymorony
tonymorony suggested changes Jun 15, 2021
View reviewed changes
Copy link

@tonymorony tonymorony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

order cancel button fix looks fine, I think it's better to remove the new ProgressBar animation for order progress (it's hard to focus eyes with it)

@ssakone
Copy link
Author

ssakone commented Jun 15, 2021

ok

@ssakone ssakone marked this pull request as ready for review June 17, 2021 08:59
@tonymorony tonymorony self-requested a review June 18, 2021 09:06
@Milerius Milerius merged commit 069bf49 into dev Jun 18, 2021
@Milerius Milerius deleted the orders_rework branch June 18, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonymorony tonymorony tonymorony approved these changes

@Milerius Milerius Awaiting requested review from Milerius

@smk762 smk762 Awaiting requested review from smk762

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Order cancelling button rework
3 participants
@ssakone @tonymorony @Milerius