S8 preps #622
Merged
S8 preps #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-check the public keys array, season heights, and timestamps before launching the daemon. This check prevents the daemon from launching if some information in the important arrays is incorrectly filled.
In the real KMD chain (not in the first blocks), block.nBits will always be greater than KOMODO_MINDIFF_NBITS. Therefore, the control will never enter this conditional statement. Also "fee stealing" is impossible, since we have notary proof tx (last tx in notary mined block).
For some reason, we were not allowed to have additional vouts in the coinbase transaction if their total was greater than 0.1 KMD. Therefore, a coinbase transaction with 2.8 KMD in vout[0] and 0.2 KMD in vout[1] was forbidden. Since this release, we are allowing such transactions. We are not using height activation here to keep the code simple; instead, we have just removed the restriction itself.
error: integer value -1 is outside the valid range of values [0, 3] for this enumeration type - https://trac.macports.org/ticket/69103 - boostorg/numeric_conversion@50a1eae
…rm64) try launch build on x86_64-apple-darwin host instead of arm-apple-darwin - actions/runner-images#9741 - https://github.com/actions/runner-images?tab=readme-ov-file#available-images
Add Season 8 pubkeys and update hardfork constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.