fix(target/python) query string fix #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test that demonstrates the fixed behavior? |
|
Sure, just added a test. Also updated description :) |
darrenjennings
suggested changes
May 1, 2019
test/targets/python/requests.js
Outdated
| }) | ||
|
|
||
| result.should.be.a.String() | ||
| result.should.eql('import requests\n\nurl = "http://mockbin.com/har"\n\nquerystring = {"param":"value"}\n\nresponse = requests.request("GET", url, params=querystring)\n\nprint(response.text)') |
There was a problem hiding this comment.
looks good. only feedback is to make output human readable using backticks. I refactored the go tests recently you can use as an example. This helps with git diffs in a future PR if tests fail.
httpsnippet/test/targets/go/native.js
Line 22 in c8e0b09
darrenjennings
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes handling of query string parameters for python/request target.
Query params can be supplied both by
queryStringandurl(http://www.softwareishard.com/blog/har-12-spec/#request). Both scenarios are supported here https://github.com/Kong/httpsnippet/blob/master/src/index.js#L164.However
python/requestswas looking only intoqueryStringwhich was a cause of bug.