Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target for raw HTTP request string (RFC 7230) #99

Merged
merged 8 commits into from
Apr 26, 2019

Conversation

irvinlim
Copy link
Contributor

@irvinlim irvinlim commented Jul 6, 2017

This target isn't really a programming language, but I found the need to build raw HTTP request strings from a HAR object. I'll just be sharing this in case the maintainers here feel it might be useful to merge in.

The output is a HTTP/1.1 request string which is fully compliant with RFC 7230/7231, the up-to-date set of IETF standards for HTTP/1.1. The name of the target or folder can be changed if anyone has a better idea.

Since I didn't know if this will be merged in, I haven't written any tests or updated the documentation. If we decide to go ahead with it, then I will add tests and docs prior to this being merged in.

@darrenjennings
Copy link
Contributor

@irvinlim We are in a bit of a transition time, but this looks good to proceed if you want to start the work. I like that you linked to the RFC, but I wonder if it makes more sense to call it http/1.1 or some readable name http1. We can always link to the RFC in the comments/description. Tests/linting/docs would be great!

@darrenjennings darrenjennings mentioned this pull request Mar 11, 2019
@irvinlim
Copy link
Contributor Author

irvinlim commented Mar 12, 2019

Hey @darrenjennings, glad to hear that Kong is still maintaining this repo! Renaming it to http/1.1 sounds good. I will add tests, linting and docs once I have the time this weekend or so.

@darrenjennings
Copy link
Contributor

our test suite is now stable on master if you would kindly rebase and add output fixtures and fix and linting issues. See #128 for inspiration.

@irvinlim
Copy link
Contributor Author

irvinlim commented Apr 26, 2019

Hope everything's fine now! I didn't have time to come up with additional tests, but feel free to add any tests for custom options and such.

Fixtures were initially failing because CRLFs weren't committed in Git, you'll have to disable Git from converting CRLF to LF:

git config core.autocrlf false

@darrenjennings darrenjennings merged commit 39adab1 into Kong:master Apr 26, 2019
@darrenjennings
Copy link
Contributor

Great work @irvinlim and thanks again for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants