Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Title Bar ignores dark mode #3150

Closed
drocx opened this issue Mar 5, 2021 · 4 comments
Closed

The Title Bar ignores dark mode #3150

drocx opened this issue Mar 5, 2021 · 4 comments
Labels
A-ui-ux Area: UI / UX / Design E-good-first-issue Experience required: Beginner / New O-windows Operating System: Windows

Comments

@drocx
Copy link

drocx commented Mar 5, 2021

Describe the bug
The Title Bar Color is white on Windows 10 with dark mode enabled.

To Reproduce
Steps to reproduce the behavior:

  1. Switch to windows dark mode
  2. Start Insomnia

Expected behavior
The Title Bar should use the dark mode like vs code or other electron apps.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10 20H2 Build 19042.844
  • App Version: 2021.1.0
@nijikokun nijikokun added the A-ui-ux Area: UI / UX / Design label Mar 5, 2021
@nijikokun
Copy link
Contributor

This is definitely a good first issue for someone who wants to get into open source, looks like we are missing or overriding an electron setting:

const { nativeTheme } = require('electron')
nativeTheme.themeSource = 'system'

@nijikokun nijikokun added the E-good-first-issue Experience required: Beginner / New label Mar 5, 2021
@roguib
Copy link
Contributor

roguib commented May 8, 2021

It seems, for this particular issue that nativeTheme.themeSource = 'system' doesn't change the color of the title bar in the current electron version of the project. It hasn't been until this PR was merged that the issue has been partially solved.

I've tried setting nativeTheme.themeSource = 'system' on different places suggested and it didn't change the color of the title bar to match the dark mode of the system. I've been researching a bit and it seems there're several workarounds to this issue such as implementing your custom title bar, use a complicated API to set the color of the bar or upgrade Electron.

@filfreire filfreire added the O-windows Operating System: Windows label Aug 12, 2022
@filfreire
Copy link
Member

Related issue: #2149

@drocx
Copy link
Author

drocx commented Dec 22, 2022

Fixed with 2022.7.0

@drocx drocx closed this as completed Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui-ux Area: UI / UX / Design E-good-first-issue Experience required: Beginner / New O-windows Operating System: Windows
Projects
None yet
Development

No branches or pull requests

4 participants