Insomnia dark theme should leverage dark theme on linux

[nguyenkien]

When user choose dark theme title bar should use system dark theme too.

Screenshots
This is how it look now

This is how it should be.

This is command I use to change it everytime I open app:
xprop -f _GTK_THEME_VARIANT 8u -set _GTK_THEME_VARIANT "dark"

Desktop (please complete the following information):

• OS: Linux
• Installation Method: Github release page
• App Version:
  Insomnia v7.1.1
  Designer 2020.1.2

[nijikokun]

I'm not sure if this is possible through the electron API, but I'd love to be enlightened. It looks awesome.

[nguyenkien]

Just foundout this on electron docs: Passing darkTheme: true when you create BrowserWindow
https://github.com/electron/electron/blob/v3.1.13/docs/api/browser-window.md

[plumcube]

May I pick up this issue?

[gschier]

I think we should discuss the implementation first. If we have to pass darkTheme: true when the app launches (when window is created), it won't be able to switch to dark when the user changes the theme.

So, a few questions:

• How do we know if a theme is dark?
• Is it possible to change the dark theme without relaunching the window?
• Would this be better as a setting that the user could toggle separate from the theme?
• I know IntelliJ used to have a setting for this on Mac. I see a vibrancy option in there that looks like it might do something similar on Mac.

[nguyenkien]

For vscode, theme have to identify them self is dark or light. You could do the same

[plumcube]

That's a good point, sublime has a similar setup I believe.

…

On Fri, May 15, 2020 at 11:06 AM Nguyễn Trung Kiên ***@***.***> wrote: For vscode, theme have to identify them self is dark or light. You could do the same [image: Screenshot from 2020-05-15 22-02-40] <https://user-images.githubusercontent.com/1940081/82065182-fa617180-96f7-11ea-9255-d1ab3b53171e.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2149 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6Q5GTZDDPXCA5XL4VD5ZDRRVK6TANCNFSM4M5HZPDA> .

-- Thanks, Ben

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.