Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show WS errors in timeline #5099

Closed
wants to merge 6 commits into from
Closed

Show WS errors in timeline #5099

wants to merge 6 commits into from

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Aug 19, 2022 •
edited
Loading

Motivation: handle error cases, and timeline more responsive.

Highlights

  • event log and timeline are now both file streams so they update the UI as events occur

TODO

  • show bad url error
  • show close connection in timeline
  • show connection errors in the timeline
  • decide where subprotocol error should be shown

@jackkav jackkav force-pushed the feature/ins-1764-display-close-codereason branch from 70a9f0c to 44c05da Compare August 19, 2022 12:41
@jackkav jackkav changed the base branch from develop to websockets August 22, 2022 07:57
@jackkav jackkav self-assigned this Aug 22, 2022
@jackkav jackkav changed the title Show WS errors in UI Show WS errors in timeline Aug 22, 2022
@jackkav
Copy link
Contributor Author

jackkav commented Aug 22, 2022 •
edited
Loading

Moved to #5100

@jackkav jackkav closed this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jackkav jackkav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jackkav