fix: request render error not display - [INS-4833] #8277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurryYangxx
force-pushed
the
fix/render-error
branch
from
a4e8452 to
04bb14b
Compare
CurryYangxx
changed the title
cwangsmv
approved these changes
Jan 7, 2025
|
Tested locally, LGTM 
|
filfreire
approved these changes
Jan 8, 2025
jackkav
reviewed
Jan 8, 2025
| if (e?.extraInfo && e?.extraInfo?.subType === RenderErrorSubType.EnvironmentVariable) { | ||
| url.searchParams.set('envVariableMissing', '1'); | ||
| url.searchParams.set('undefinedEnvironmentVariables', e?.extraInfo?.undefinedEnvironmentVariables); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could this logic be cleaned up? Or expressed more simply.
There was a problem hiding this comment.
Currently passing the error message through the URL parameter is not a good way. We could keep the status quo first. I plan to find a new way to replace this
CurryYangxx
force-pushed
the
fix/render-error
branch
from
04bb14b to
4e85cab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8068, we removed the request error modal because some of the errors are also displayed in the preview panel.
But we ignored the request render error, so we restored the modal box and used it to display rendering errors.