feat(patch) patch nginx to support stream upstream ssl function #582
Conversation
hutchic
force-pushed
the
stream-upstream-tls
branch
from
0c372a3 to
25a7c1e
Compare
oowl
force-pushed
the
stream-upstream-tls
branch
from
25a7c1e to
09fd761
Compare
...hes/patches/1.21.4.1/nginx-1.21.4_03-stream_upstream_client_certificate_and_ssl_verify.patch
Show resolved
Hide resolved
...hes/patches/1.21.4.1/nginx-1.21.4_03-stream_upstream_client_certificate_and_ssl_verify.patch
Show resolved
Hide resolved
...hes/patches/1.21.4.1/nginx-1.21.4_03-stream_upstream_client_certificate_and_ssl_verify.patch
Show resolved
Hide resolved
|
Do we need to maintain OpenResty 1.19.x now ? |
oowl
force-pushed
the
stream-upstream-tls
branch
2 times, most recently
from
a6185f7 to
0c372a3
Compare
oowl
force-pushed
the
stream-upstream-tls
branch
from
0c372a3 to
20e1e82
Compare
|
@chronolaw I also think this may cause compatibility issues, and I can remove the if kong don't need it |
oowl
force-pushed
the
stream-upstream-tls
branch
from
8c37a95 to
d08c26d
Compare
|
LGTM. |
|
We do not need to support 1.19 for this feature. Suggest remove it. |
|
I checked the patch of 1.21.4.1, LGTM. |
|
@attenuation Can you please remove |
|
@bungle done |
|
relying on Kong/kong#9947 to assure patch's validality |
| @@ -150,7 +150,7 @@ pipeline { | |||
| environment { | |||
| GITHUB_SSH_KEY = credentials('github_bot_ssh_key') | |||
| PATH = "/home/ubuntu/bin/:${env.PATH}" | |||
| KONG_SOURCE = "3.0.0.0" | |||
| KONG_SOURCE = "master" | |||
There was a problem hiding this comment.
why was this done? what purpose does this serve? did you understand the intent previously before you changed this or did you just change this to "make it work?"
We now have two stages that run against Kong EE master and none that run against 3.0.0.0 so we no longer have a backwards compatibility CI check. If we no longer care about backwards compatibility why not remove the entire check instead of run kong-ee@master twice?
There was a problem hiding this comment.
The "backward compat" is testing a behaviour introduced by a bug,
kbt is not pinned correctly https://github.com/Kong/kong-ee/pull/4238/files and always pointing to master. So I don't
understand what are we testing here to use the master branch of this
repo against 3.0.0.0; unless we intended to always build 3.0.0.0 with master kbt.
I saw a commit and PR (#622)
that doesn't tell me anything why it's being added, without knowing why
it was there, i'm not feeling comfortable to just remove it but instead make it pass. That being said, i'm okay to just remove this.
Patches will stay in kong/kong-ee repo in the future, hopefully at that time we don't need to try 5 different places to correctly bump/pin a dependency.
|
relying on Kong/kong#9947 to assure patch's validality |
patch Nginx code to support stream upstream SSL function
FTI-1479