fix(healthchecks) fix active healthchecks in stream module #4616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
approved these changes
May 15, 2019
bungle
reviewed
May 15, 2019
hishamhm
force-pushed
the
fix/healthchecks-active-stream
branch
2 times, most recently
from
7845a69 to
a6ff1bf
Compare
|
nice follow up! didn't know this was disabled. 👍 |
Adds a utility function that allows killing a thread created with helpers.tcp_server early, by sending a special message.
Instead of disabling active healthchecks in the stream module
altogether (which was done to avoid duplicate active healthchecks),
what we need to do is to run the "tcp" type healthchecks in the
stream module, and the other ones ("http", "https") in the http
module.
This serves as a regression test for the problem in Kong/lua-resty-healthcheck#19 The new tests are marked as #flaky because they are timing-dependent, so we we will not run them regularly in CI.
* fixes TCP success reporting in active healthchecks for the stream module.
hishamhm
force-pushed
the
fix/healthchecks-active-stream
branch
from
a6ff1bf to
ba13112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of disabling active healthchecks in the stream module altogether (which was done to avoid duplicate active healthchecks), what we need to do is to run the "tcp" type healthchecks in the stream module, and the other ones ("http", "https") in the http module.
For active healthchecks on stream to work, we need to bump lua-resty-healthcheck.
This PR also adds a test for active healthchecks using stream, which also serves like a regression test for Kong/lua-resty-healthcheck#19