fix(kbutton): fix unfocusing of kbutton #1984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clicking then releasing and moving away from a
KButton
without a subsequent DOM re-render leaves the KButton in its darker 'focus' state.This PR changes some selectors to use
:focus-visible
over just:focus
to keep the desired coloring when the browser heuristics have decided that the button should look focused, but doesn't apply them otherwise.I'm pretty sure this is the correct way to do this going from reading:
https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible#focus_vs_focus-visible
My understanding form the above is that buttons generally should use
:focus-visible
, whereas something like an input field you should generally use ':focus' i.e. with the input field example, if you are changing the border color on 'focus' you probably want that change to stay when you move the pointer away from the input field.But if folks have a different approach, happy to close this and go with something else.
Also, please shout if its not clear what the issue is, its a very subtle thing and easy to miss.
P.S guessing there could be other components that have similar issues, but I'm not super familiar with all of them so this only addresses KButton.
PR Checklist