fix(kradio): show-card-radio and card-orientation props [KHCP-13540] #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portikM
requested review from
adamdehaven,
jillztom,
Justineo and
a team
as code owners
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamdehaven
requested changes
Nov 7, 2024
docs/components/radio.md
Outdated
Comment on lines
178
to
220
| <KRadio | ||
| v-model="horizontalCard" | ||
| card | ||
| card-orientation="horizontal" | ||
| description="Choose this option if you want your APIs to only be accessible from within your private network." | ||
| label="Private" | ||
| selected-value="private" | ||
| > | ||
| <KBadge appearance="success"> | ||
| Recommended | ||
| </KBadge> | ||
| </KRadio> | ||
| <KRadio | ||
| v-model="horizontalCard" | ||
| card | ||
| card-orientation="horizontal" | ||
| description="Choose this option if you want your APIs to be publicly accessible by anyone on the internet." | ||
| label="Public" | ||
| selected-value="public" | ||
| /> | ||
|
|
||
| ```html | ||
| <KRadio | ||
| card-orientation="horizontal" | ||
| v-model="cardRadio" | ||
| description="Choose this option if you want your APIs to only be accessible from within your private network." | ||
| card | ||
| label="Private" | ||
| selected-value="private" | ||
| > | ||
| <KBadge appearance="success"> | ||
| Recommended | ||
| </KBadge> | ||
| </KRadio> | ||
| <KRadio | ||
| card-orientation="horizontal" | ||
| v-model="cardRadio" | ||
| description="Choose this option if you want your APIs to be publicly accessible by anyone on the internet." | ||
| card | ||
| label="Public" | ||
| selected-value="public" | ||
| /> | ||
| ``` |
There was a problem hiding this comment.
super-nit: flip the order here so that the "Public" option is first and recommended.
There was a problem hiding this comment.
Yeah that's super nit
I'll keep it as is if you don't mind (this order pleases me aesthetically 😅)
Co-authored-by: Adam DeHaven <[email protected]>
adamdehaven
approved these changes
Nov 13, 2024
kongponents-bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
## [9.14.12](v9.14.11...v9.14.12) (2024-11-13) ### Bug Fixes * **kradio:** show-card-radio and card-orientation props [KHCP-13540] ([#2504](#2504)) ([61b1d74](61b1d74))
|
🎉 This PR is included in version 9.14.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-13540
Adds
cardOrientationandshowCardRadioprops