Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ktextarea): add autosize for <KTextArea> #2587

Merged
merged 7 commits into from
Feb 5, 2025
Merged

Conversation

Justineo
Copy link
Contributor

@Justineo Justineo commented Jan 22, 2025

Summary

  • Introduced a new autosize prop that dynamically adjusts the height of the textarea based on its content.
  • Added an enhancement for resizable textareas where double-clicking the drag handle resets the default sizing (which Firefox supports natively)
  • Added a new browser utilities module for handling user-agent detection and ensuring browser compatibility.

Jan-22-2025 10-22-48

@Justineo Justineo requested review from adamdehaven, jillztom and a team as code owners January 22, 2025 04:00
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 31e2e0e
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/6794a96a13193f0008a6d872
😎 Deploy Preview https://deploy-preview-2587--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 31e2e0e
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/6794a96a421b710008e6fe21
😎 Deploy Preview https://deploy-preview-2587--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/utilities/browser.ts Show resolved Hide resolved
src/components/KTextArea/KTextArea.vue Outdated Show resolved Hide resolved
src/components/KTextArea/KTextArea.vue Show resolved Hide resolved
src/components/KTextArea/KTextArea.vue Show resolved Hide resolved
src/components/KTextArea/KTextArea.vue Show resolved Hide resolved
@Justineo Justineo enabled auto-merge (squash) January 22, 2025 06:52
docs/components/textarea.md Show resolved Hide resolved
src/components/KTextArea/KTextArea.cy.ts Outdated Show resolved Hide resolved
src/components/KTextArea/KTextArea.cy.ts Show resolved Hide resolved
src/components/KTextArea/KTextArea.vue Show resolved Hide resolved
src/components/KTextArea/KTextArea.vue Outdated Show resolved Hide resolved
@Justineo Justineo force-pushed the feat/autosize-textarea branch from f7ded54 to 59de1d1 Compare January 23, 2025 06:19
@Justineo Justineo requested a review from adamdehaven January 24, 2025 02:18
@Justineo Justineo requested a review from adamdehaven February 5, 2025 02:51
@Justineo
Copy link
Contributor Author

Justineo commented Feb 5, 2025

@adamdehaven All comments are resolved. Please take a look again.

@Justineo Justineo merged commit 1d9d7c4 into main Feb 5, 2025
10 checks passed
@Justineo Justineo deleted the feat/autosize-textarea branch February 5, 2025 03:06
kongponents-bot pushed a commit that referenced this pull request Feb 5, 2025
# [9.19.0](v9.18.5...v9.19.0) (2025-02-05)

### Features

* **ktextarea:** add `autosize` for `<KTextArea>` ([#2587](#2587)) ([1d9d7c4](1d9d7c4))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kongponents-bot
Copy link
Collaborator

Preview package from this PR in consuming application

In consuming application project install preview version of kongponents generated by this PR:

@kong/kongponents@pr-2587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants