fix(translate) use Ingress-specific regex prefix #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
force-pushed
the
fix/special-prefix
branch
from
4c4c632 to
5f8dbc5
Compare
rainest
force-pushed
the
fix/special-prefix
branch
from
5f8dbc5 to
babc24a
Compare
dndx
reviewed
Sep 22, 2022
randmonkey
reviewed
Sep 22, 2022
|
Can we add a tests, that overrides the |
Translate between an Ingress-compatible regex prefix and the Kong regex prefix. Allow users to override the default regex prefix. Add tests for regex Ingress paths using the prefix.
rainest
force-pushed
the
fix/special-prefix
branch
from
babc24a to
d02fd2d
Compare
Move non-legacy logic inside maybePrependPrefix. Add a test for a default prefix path on an Ingress that overrides the prefix. Further CHANGELOG updates.
rainest
force-pushed
the
fix/special-prefix
branch
from
d02fd2d to
eb5569f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Translate between an Ingress-compatible regex prefix and the Kong regex prefix. Allow users to override the default regex prefix using an annotation.
Add tests for regex Ingress paths using the prefix.
By default, Ingress paths beginning with
/~will translate to Kong route paths beginning with~. This functionality is not version-gated, with the expectation that such paths are uncommon in the wild. For users that do need these paths translated verbatim, overriding the prefix with thekonghq.com/regex-prefixallows you to preserve/~-prefixed paths as they are.Which issue this PR fixes:
Fix #2945
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR