-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace debugging endpoints integration tests with envtest #4094
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4094 +/- ##
=======================================
+ Coverage 60.1% 60.3% +0.2%
=======================================
Files 150 150
Lines 16727 16736 +9
=======================================
+ Hits 10066 10107 +41
+ Misses 6024 5997 -27
+ Partials 637 632 -5
☔ View full report in Codecov by Sentry. |
Co-authored-by: Jakub Warczarek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the intention of ripping things that do not really depend on Kong instance out of integration tests suite. I see the value in being able to run tests locally, quickly, and in isolation (sadly cannot say that about integration tests). 👍
Co-authored-by: Grzegorz Burzyński <[email protected]>
What this PR does / why we need it:
This PR replaces unnecessary integration tests - that test debugging and readiness endpoints of KIC - with envtest based test.
Which issue this PR fixes:
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR