Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stream) add upstream ssl ffi function and stream client ssl ffi function #50

Merged
merged 15 commits into from
Jan 3, 2023
Merged

feat(stream) add upstream ssl ffi function and stream client ssl ffi function #50

merged 15 commits into from
Jan 3, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Nov 2, 2022 •
edited
Loading

  1. extend stream module upstream ssl client function to support dynamic upstream ssl cert
  2. extend stream tls request client_certificate_chain

@fffonion
Copy link
Contributor

fffonion commented Nov 7, 2022

might consider make a common helper function to reduce copy paste. although r is different, c and ssl is the same struct that shared between http and stream.

@oowl oowl requested review from fffonion and chronolaw November 17, 2022 08:56
@oowl
Copy link
Member Author

oowl commented Nov 17, 2022

befcfb0 this pr will be revert because openresty official API support this feature, wanting for this I will rebase to master.

chronolaw
chronolaw reviewed Dec 7, 2022
View reviewed changes
lualib/resty/kong/tls.lua Show resolved Hide resolved
src/ngx_http_lua_kong_common.h Outdated Show resolved Hide resolved
stream/src/ngx_stream_lua_kong_module.c Outdated Show resolved Hide resolved
@oowl oowl force-pushed the stream-upstream-tls branch from 3c6624d to a18ca8c Compare December 12, 2022 09:23
@oowl oowl force-pushed the stream-upstream-tls branch from eca03e9 to f4f97af Compare December 12, 2022 17:38
@oowl oowl requested a review from chronolaw December 13, 2022 03:01
@oowl oowl mentioned this pull request Dec 15, 2022
Merged
1 task
@catbro666
Copy link
Contributor

How about adjusting the codes under stream/src into src/stream, i think it’s more proper there.

@oowl
Copy link
Member Author

oowl commented Dec 22, 2022

@catbro666 I think it's not needed because many Nginx modules use this file struct in the code base.

catbro666
catbro666 reviewed Dec 23, 2022
View reviewed changes
t/stream/001-upstream-tls.t Outdated Show resolved Hide resolved
t/stream/001-upstream-tls.t Show resolved Hide resolved
t/stream/001-upstream-tls.t Outdated Show resolved Hide resolved
t/stream/001-upstream-tls.t Outdated Show resolved Hide resolved
t/stream/003-tls.t Show resolved Hide resolved
t/stream/001-upstream-tls.t Show resolved Hide resolved
t/stream/001-upstream-tls.t Show resolved Hide resolved
t/stream/001-upstream-tls.t Show resolved Hide resolved
t/stream/001-upstream-tls.t Show resolved Hide resolved
@oowl oowl requested a review from catbro666 December 26, 2022 04:16
@fffonion fffonion merged commit fec7331 into master Jan 3, 2023
@fffonion fffonion deleted the stream-upstream-tls branch January 3, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion left review comments

@chronolaw chronolaw chronolaw approved these changes

@catbro666 catbro666 Awaiting requested review from catbro666

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oowl @fffonion @catbro666 @chronolaw