Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read properties of undefined (reading 'nodeData') #347

Open
AmreshSinha opened this issue Dec 25, 2024 · 2 comments
Open

Comments

@AmreshSinha
Copy link

AmreshSinha commented Dec 25, 2024

I was trying to open a workflow
specifically this one: https://openart.ai/workflows/discus_disastrous_37/free-digital-human/bcculjSnGEcDuGhoNhkd
on a freshly installed comfyui with manager
and after installing all the missing custom nodes from manager it started to throw this error:

Platform: Apple M3 Pro Macbook

Loading aborted due to error reloading workflow data

TypeError: Cannot read properties of undefined (reading 'nodeData')
TypeError: Cannot read properties of undefined (reading 'nodeData')
    at ComfyNode.onConnectionsChange (http://127.0.0.1:8188/extensions/ComfyUI-VideoHelperSuite/js/VHS.core.js:450:76)
    at ComfyNode.configure (http://127.0.0.1:8188/assets/index-DIU5yZe9.js:35142:37)
    at ComfyNode.configure (http://127.0.0.1:8188/assets/index-DIU5yZe9.js:121249:15)
    at LGraph2.configure (http://127.0.0.1:8188/assets/index-DIU5yZe9.js:44993:17)
    at LGraph$1.configure (http://127.0.0.1:8188/assets/index-DIU5yZe9.js:120908:26)
    at LGraph.configure (http://127.0.0.1:8188/extensions/ComfyUI-Custom-Scripts/js/reroutePrimitive.js:14:29)
    at ComfyApp.loadGraphData (http://127.0.0.1:8188/assets/index-DIU5yZe9.js:121365:18)
    at async app.loadGraphData (http://127.0.0.1:8188/extensions/ComfyUI-Manager/components-manager.js:773:9)
    at async loadWorkflow (http://127.0.0.1:8188/assets/index-DIU5yZe9.js:121021:11)
    at async ComfyApp.setup (http://127.0.0.1:8188/assets/index-DIU5yZe9.js:121026:30)
This may be due to the following script:
/extensions/ComfyUI-VideoHelperSuite/js/VHS.core.js
Screenshot 2024-12-26 at 12 32 34 AM




I am not sure as to why this is coming up. I was not able to find any existing issue on this as well.

I tried debugging (jk just added some print statements)

Screenshot 2024-12-26 at 12 50 23 AM

and interestingly it printed it 2 times. First time it logged out a class. the second time undefined sadly.

Screenshot 2024-12-26 at 12 47 57 AM

Note: I am a newbie to comfyui.

@AustinMroz
Copy link
Collaborator

VHS includes code to assist in migrating of older workflows like this one, but it seems there's been changes to ComfyUI itself that break the method I was using to do so. I'll push a quick fix to ensure you don't get an error on load, but some links will need to be manually fixed.

@AustinMroz
Copy link
Collaborator

VHS added connections for audio input and output in an overly convoluted VHS_AUDIO format for internal use. A number of other custom nodes adopted the format since it was the only option available. Since then ComfyUI introduced a native AUDIO format which is much nicer for actual usage which VHS has swapped to, but it requires adding in "Audio to legacy VHS_AUDIO" and "Legacy VHS_AUDIO to Audio" nodes to maintain compatibility with other nodes that haven't updated.

AustinMroz added a commit that referenced this issue Dec 25, 2024
AustinMroz added a commit that referenced this issue Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants