Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improved pre commit checks in UI #4010

Merged
merged 3 commits into from
Jan 28, 2025
Merged

chore: improved pre commit checks in UI #4010

merged 3 commits into from
Jan 28, 2025

Conversation

berezinant
Copy link
Contributor

@berezinant berezinant commented Jan 27, 2025 •
edited
Loading

  • fixed missed linting errors
  • improved pre commit checks
    those checks should only affect commits when there are staged files from plugin-base-frontend

whyoleg
whyoleg approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@whyoleg whyoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement !

@berezinant berezinant merged commit ac6e7f1 into master Jan 28, 2025
14 checks passed
@berezinant berezinant deleted the ktl-fix-precommit-checks branch January 28, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyoleg whyoleg whyoleg approved these changes

@nikpachoo nikpachoo Awaiting requested review from nikpachoo

@zoobestik zoobestik Awaiting requested review from zoobestik

@krutilov krutilov Awaiting requested review from krutilov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berezinant @whyoleg