Fix merging of implicit expect/actual with a single declaration #4016
+76
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
commented
Feb 4, 2025
| ) { | ||
| pagesGenerationStage = { root -> | ||
| val cl = root.dfs { it.name == "Skiko" && it is ClasslikePageNode } ?: throw IllegalStateException() | ||
| assertEquals(2, cl.children.count { it.name == "[jvm]isShowing" }) |
There was a problem hiding this comment.
Before the fix, there were 2 pages: [jvm]isShowing and isShowing with the different names, but the same DRI.
vmishenev
deleted the
vmishenev/3685-fix-merging-of-implicit-expect-actual-with-a-single-declaration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea of this fix is that pages with implicit expect/actual declarations and a single declaration should have the same name since they are merged by
PageMergerbased on the page name. Before the fix, pages with the same DRI/path were unmerged, which caused an exception.