Update error message in writableSegment
#398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhinkin
approved these changes
Oct 10, 2024
|
Thanks for improving the message! |
Egorand
added a commit
to Egorand/kotlinx-io
that referenced
this pull request
Nov 14, 2024
* 'develop' of github.com:Kotlin/kotlinx-io: Publish Segment.size and Segment.remainingCapacity (Kotlin#409) Generate JPMS modules (Kotlin#406) Document empty bytestring factory (Kotlin#396) Update error message in `writableSegment` (Kotlin#398) Improve documentation (Kotlin#395)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During implementation for support of
kotlinx-ioincryptography-kotlinat one point I've started to receive the error aboutunexpected capacity, but it was not really informative. The reason for this was, that I haven't handled the case with output of zero size here.It would be nice to have the error message more clear on what's wrong, when using
UnsafeBufferOperations.writeToTail