Added ability to specify inclusion filter for source sets #726
Conversation
shanshin
force-pushed
the
sourceset-inclusion
branch
from
5ac91be to
cd71b38
Compare
| } | ||
| ``` | ||
|
|
||
| This way, only classes from the `main` source set will be included in the report, but not from others. |
There was a problem hiding this comment.
Isn't this includedSourceSets then?
There was a problem hiding this comment.
Or at least excludeEverySourceSetExcept
There was a problem hiding this comment.
I would like to get away from naming included. On the other hand, such things are now called included in the entire DSL.
There was a problem hiding this comment.
Ok, let it be included for now
There was a problem hiding this comment.
I'm afraid we can move from this naming only for all functions at once, when we'll migrate whole Kover plugin
There was a problem hiding this comment.
Yes, I took this into account
|
|
||
| val included = variant.excludedOtherSourceSets.get() | ||
| // if `test` is not included so we need to check it | ||
| if (compilationName == "test" && "test" !in included) { |
There was a problem hiding this comment.
Isn't it the same condition as included.isNotEmpty() && compilationName !in included?
Also, you can add a test case for "test" source set name.
There was a problem hiding this comment.
Indeed, I was a little hasty to add a separate condition
| assertTrue(buildResult.isSuccessful, "Build should be successful") | ||
| classCounter("kotlinx.kover.examples.sourcesets.MainClass").assertAbsent() | ||
| classCounter("kotlinx.kover.examples.sourcesets.FooClass").assertAbsent() | ||
| classCounter("kotlinx.kover.examples.sourcesets.ExtraClass").assertPresent() |
There was a problem hiding this comment.
Add classCounter("kotlinx.kover.examples.sourcesets.TestClasses") to this test and all above
|
|
||
| val included = variant.includedSourceSets.get() | ||
|
|
||
| if (included.isEmpty() && compilationName == "test") { |
There was a problem hiding this comment.
Are tests excluded by default? Is it mentioned somewhere in the documentation?
There was a problem hiding this comment.
Yes, test source set excluded by default.
| val builder = StringBuilder() | ||
| koverBlocks.forEach { block -> | ||
| builder.appendLine() | ||
| builder.append(block(language, "8.12")) |
There was a problem hiding this comment.
Is 8.12 a Gradle version? Shouldn't it be some constant?
There was a problem hiding this comment.
Yes, any version of Gradle with support for assign operator redefinition is needed here.
Resolves #714