Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weaken receiver type of toPersistentHashSet to Iterable #77

Closed
GlassBricks opened this issue Jun 23, 2020 · 1 comment
Closed

Weaken receiver type of toPersistentHashSet to Iterable #77

GlassBricks opened this issue Jun 23, 2020 · 1 comment
Assignees
@qurbonzoda
Labels
enhancement

Comments

@GlassBricks
Copy link

GlassBricks commented Jun 23, 2020 •
edited
Loading

All other toImmutable and toPersistent functions for immutable/persistent lists/sets take Iterable as their receiver, however toPersistentHashSet takes a Set.

toHashSet in the kotlin stdlib also takes Iterable.

This is inconvenient when converting from some other collection into a persistent hash set.
qurbonzoda pushed a commit that referenced this issue Aug 9, 2020
Weaken receiver type of toPersistentHashSet to Iterable #77
9567549
@qurbonzoda qurbonzoda self-assigned this Aug 9, 2020
qurbonzoda pushed a commit that referenced this issue Aug 20, 2020
@qurbonzoda
Weaken receiver type of toPersistentHashSet to Iterable #77
b4de092
@qurbonzoda
Copy link
Contributor

The change was released with version 0.3.3 of this library.
Thanks for your feedback!
Please open new issues if you find any fields for improvements. Always glad to see your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qurbonzoda qurbonzoda

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qurbonzoda @GlassBricks