-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove sampleStart
and sampleEnd
comments from example in coroutine-context-and-dispatchers.md
#4081
Conversation
…e-context-and-dispatchers.md
This example isn't running correctly, but fails with
|
I don't know if the problem is in the coroutines here or in some restrictions in the playground. Maybe it's just worth deleting //sampleStart and sampleEnd comments and making this example non-runnable. |
This example is being run as part of our tests (https://github.com/Kotlin/kotlinx.coroutines/blob/master/kotlinx-coroutines-core/jvm/test/guide/test/DispatcherGuideTest.kt#L37-L44); so, these are probably just the playground restrictions. Also, making the example non-runnable would remove the test automatically, and I don't think we want that. |
It's https://youtrack.jetbrains.com/issue/KTL-108 unfortunately |
I also launched it before I created this PR: locally, this example passes w/o problems.
|
Won't that also remove the test generated by Knit? |
…e comments about sample start and sample end
I don't see any changes after running knit locally. Removed runnability and sample start/end comments. |
sampleStart
and sampleEnd
comments in coroutine-context-and-dispatchers.md
sampleStart
and sampleEnd
comments in coroutine-context-and-dispatchers.mdsampleStart
and sampleEnd
comments from example in coroutine-context-and-dispatchers.md
Thanks! |
…routine-context-and-dispatchers.md (Kotlin#4081)
…routine-context-and-dispatchers.md (Kotlin#4081)
https://kotlinlang.org/docs/coroutine-context-and-dispatchers.html#jumping-between-threads
UPD: removed sampleStart and sampleEnd comments.
Fix this sample not being runnable:
