-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced dovecot authN module #946
Conversation
This work is heavily based on prior art by Giel van Schijndel, however the code was made Python 3 compatible, error checking has been improved, and tests were introduced: $ python setup.py test --extras --addopts "-k auth" [skipped] Name Stmts Miss Branch BrPart Cover ------------------------------------------------------------- radicale/auth/dovecot.py 76 2 26 2 96% [skipped] === 34 passed, 16 skipped, 198 deselected in 2.35 seconds ===
JFYI, Travis CI fails on other tests not the ones introduced by this PR. |
I use https://github.com/comzeradd/radicale-imap works great 👍 |
The application is different, this authN module is needed if you want to integrate with Dovecot's authentication backend. I am going to make another PR that uses Dovecot storage API to store calendars and vcards soon, too. |
Also, passing credentials over a Unix socket is faster and more secure than making an external IMAP call. At least, when Radicale is running on the same instance. |
The imap plugin was the only way for me, your PR looks like very nice! |
767d614
to
41bccb2
Compare
It's been more than 18 months since this PR was submitted. Is there anything I could do to expedite its approval and merging into the master branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase to latest Radicale version 3
Wow! 4 years turn around, this is my first :). Will try to carve out time and see what I can do. |
@galaxy4public any update - otherwise I will close for now?! |
superseeded |
This work is heavily based on prior art by Giel van Schijndel (#200),
however the code was made Python 3 compatible, error checking
has been improved, and tests were introduced: