Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced dovecot authN module #946

Closed
wants to merge 3 commits into from

Conversation

galaxy4public
Copy link

This work is heavily based on prior art by Giel van Schijndel (#200),
however the code was made Python 3 compatible, error checking
has been improved, and tests were introduced:

$ python setup.py test --extras --addopts "-k auth"
[skipped]
Name                        Stmts   Miss Branch BrPart  Cover
-------------------------------------------------------------
radicale/auth/dovecot.py       76      2     26      2    96%
[skipped]
=== 34 passed, 16 skipped, 198 deselected in 2.35 seconds ===

This work is heavily based on prior art by Giel van Schijndel,
however the code was made Python 3 compatible, error checking
has been improved, and tests were introduced:

$ python setup.py test --extras --addopts "-k auth"
[skipped]
Name                        Stmts   Miss Branch BrPart  Cover
-------------------------------------------------------------
radicale/auth/dovecot.py       76      2     26      2    96%
[skipped]
=== 34 passed, 16 skipped, 198 deselected in 2.35 seconds ===
@galaxy4public
Copy link
Author

JFYI, Travis CI fails on other tests not the ones introduced by this PR.

@Tntdruid
Copy link

I use https://github.com/comzeradd/radicale-imap works great 👍

@galaxy4public
Copy link
Author

The application is different, this authN module is needed if you want to integrate with Dovecot's authentication backend. I am going to make another PR that uses Dovecot storage API to store calendars and vcards soon, too.

@galaxy4public
Copy link
Author

Also, passing credentials over a Unix socket is faster and more secure than making an external IMAP call. At least, when Radicale is running on the same instance.

@Tntdruid
Copy link

The imap plugin was the only way for me, your PR looks like very nice!

@Unrud Unrud force-pushed the master branch 3 times, most recently from 767d614 to 41bccb2 Compare August 31, 2020 12:14
@galaxy4public
Copy link
Author

It's been more than 18 months since this PR was submitted. Is there anything I could do to expedite its approval and merging into the master branch?

Copy link
Collaborator

@pbiering pbiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase to latest Radicale version 3

@pbiering pbiering added feature need:reporter feedback feedback from reporter required labels Mar 1, 2024
@galaxy4public
Copy link
Author

please rebase to latest Radicale version 3

Wow! 4 years turn around, this is my first :). Will try to carve out time and see what I can do.

@pbiering pbiering added the old version relates to no longer supported versions label Mar 9, 2024
@pbiering
Copy link
Collaborator

pbiering commented Oct 8, 2024

@galaxy4public any update - otherwise I will close for now?!

@pbiering pbiering added the superseeded superseeded by other ticket label Oct 31, 2024
@pbiering
Copy link
Collaborator

superseeded

@pbiering pbiering closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature need:reporter feedback feedback from reporter required old version relates to no longer supported versions superseeded superseeded by other ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants