Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top margins removed from children when tables are displayed on multiple pages #1254

Closed
liZe opened this issue Nov 21, 2020 · 0 comments
Closed

Top margins removed from children when tables are displayed on multiple pages #1254

liZe opened this issue Nov 21, 2020 · 0 comments
Labels
bug Existing features not working as expected
Milestone
52.2

Comments

@liZe
Copy link
Member

liZe commented Nov 21, 2020

When tables are displayed on multiple pages, top margins are removed from first children of cells.
@liZe liZe added the bug Existing features not working as expected label Nov 21, 2020
@liZe liZe closed this as completed in 70229de Nov 21, 2020
liZe added a commit that referenced this issue Nov 21, 2020
@liZe
Don’t render table cells as if they are on empty pages
236d1dd 
The page_is_empty was probably set to True to force rendering, but using
max_position=inf should already allow all cells to be rendered.

When cells are rendered with page_is_empty set to True, the top margin of their
first children is removed, because margins are always removed at the top of
blocks split between multiple pages.

Fix #1254.
@liZe liZe added this to the 52.2 milestone Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing features not working as expected
Projects
None yet
Milestone
52.2
Development

No branches or pull requests
1 participant
@liZe