Bitmap fonts #1644
Merged
Bitmap fonts #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liZe
added
feature
liZe
force-pushed
the
bitmap-fonts
branch
2 times, most recently
from
d261bdf to
c419923
Compare
This commit breaks other fonts because of the 1-byte characters.
Put everything related to font tweaks into the Font class, where it belongs.
Previously, the base size was 1, meaning that all sizes could be floats. Using the font size as the base size enables sizes to be integers, avoids rounding errors and and give pixel-perfect rendering when rasterized.
The glyf table may not be available for such fonts. Fortunately, Fonttools provides a getGlyphID method on the font object that does what we want with no assumption about the available tables.
They should actually be 0 if everything goes well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to handle OpenType bitmap fonts (otb), providing a pixel-perfect rendering when mixed with rasterizers like Ghostscript or Poppler.
Fix #1645.