Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for use when frozen #269

Merged
merged 2 commits into from
Sep 28, 2015
Merged

Conversation

andrewleech
Copy link
Contributor

Use appropriate path to find resource when frozen (using py2exe etc.)

Use appropriate path to find resource when frozen (using py2exe etc.)
@SimonSapin
Copy link
Member

I’m not familiar with py2exe, but this looks reasonable.

The Travis-CI build fails with flake8 errors:

weasyprint/html.py:37:80: E501 line too long (95 > 79 characters)
weasyprint/html.py:38:36: E251 unexpected spaces around keyword / parameter equals

(You can use pip install flake8 to run it locally.) Please fix that, and this should be good to go.

@andrewleech
Copy link
Contributor Author

Hi,
I've fixed the formatting to satisfy flake8.
There's another issue with the pypy build, have you seen it before?
If not it's probably related to my change somehow.

@SimonSapin
Copy link
Member

Yeah, this is probably https://bitbucket.org/pypy/pypy/issues/1357/lxml-not-returning-the-same-proxy-object , though it’s the first time I see it happen in the test suite.

Looks good, thanks!

SimonSapin added a commit that referenced this pull request Sep 28, 2015
Add support for use when frozen
@SimonSapin SimonSapin merged commit 0040f47 into Kozea:master Sep 28, 2015
@andrewleech
Copy link
Contributor Author

Great thanks!

jsonn referenced this pull request in jsonn/pkgsrc Jan 8, 2016
Version 0.25
------------

Released on 2015-12-17.

New features:

* Support the 'q' unit.

Bug fixes:

* `#285: <https://github.com/Kozea/WeasyPrint/issues/285>`_:
  Fix a crash happening when splitting lines.
* `#284: <https://github.com/Kozea/WeasyPrint/issues/284>`_:
  Escape parenthesis in PDF links.
* `#280: <https://github.com/Kozea/WeasyPrint/pull/280>`_:
  Replace utf8 with utf-8 for gettext/django compatibility.
* `#269: <https://github.com/Kozea/WeasyPrint/pull/269>`_:
  Add support for use when frozen.
* `#250: <https://github.com/Kozea/WeasyPrint/issues/250>`_:
  Don't crash when attachments are not available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants