Use cssselect2 instead of cssselect + lxml #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's go! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using cssselect2 makes WeasyPrint free from lxml (close #440), and gives us hope on our long way to close #57. A lot of things in the private API have changed, mainly to bring the base URL everywhere, but there's no real big change.
The only real downside is the loss of the source line in various logging messages. ElementTree and html5lib don't store the
sourcelineattributes in elements (see html5lib/html5lib-python#97), WeasyPrint can't do anything without this.If anyone is interested in this change (and in cssselect2), please read Kozea/cssselect2#5. And don't hesitate to contribute if you're interested in CSS Selectors Level 4!