Prevent endless loop and index out of range in pagination #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @Tontyna (as usual). |
|
This time no conflicts with the famous nonexistent guide of style 🎉 |
netbsd-srcmastr
referenced
this pull request
in NetBSD/pkgsrc
Feb 21, 2019
Version 45 ---------- Released on 2019-02-20. WeasyPrint now has a `code of conduct <https://github.com/Kozea/WeasyPrint/blob/master/CODE_OF_CONDUCT.rst>`_. A new website has been launched, with beautiful and useful graphs about speed and memory use across versions: check `WeasyPerf <https://kozea.github.io/WeasyPerf/index.html>`_. Dependencies: * Python 3.5+ is now needed, Python 3.4 is not supported anymore Bug fixes: * `798 <https://github.com/Kozea/WeasyPrint/pull/798>`_: Prevent endless loop and index out of range in pagination * `767 <https://github.com/Kozea/WeasyPrint/issues/767>`_: Add a ``--quiet`` CLI parameter * `784 <https://github.com/Kozea/WeasyPrint/pull/784>`_: Fix library loading on Alpine * `791 <https://github.com/Kozea/WeasyPrint/pull/791>`_: Use path2url in tests for Windows * `789 <https://github.com/Kozea/WeasyPrint/pull/789>`_: Add LICENSE file to distributed sources * `788 <https://github.com/Kozea/WeasyPrint/pull/788>`_: Fix pending references * `780 <https://github.com/Kozea/WeasyPrint/issues/780>`_: Don't draw patterns for empty page backgrounds * `774 <https://github.com/Kozea/WeasyPrint/issues/774>`_: Don't crash when links include quotes * `637 <https://github.com/Kozea/WeasyPrint/issues/637>`_: Fix a problem with justified text * `763 <https://github.com/Kozea/WeasyPrint/pull/763>`_: Launch tests with Python 3.7 * `704 <https://github.com/Kozea/WeasyPrint/issues/704>`_: Fix a corner case with tables * `804 <https://github.com/Kozea/WeasyPrint/pull/804>`_: Don't logger handlers defined before importing WeasyPrint * `109 <https://github.com/Kozea/WeasyPrint/issues/109>`_, `748 <https://github.com/Kozea/WeasyPrint/issues/748>`_: Don't include punctuation for hyphenation * `770 <https://github.com/Kozea/WeasyPrint/issues/770>`_: Don't crash when people use uppercase words from old-fashioned Microsoft fonts in tables, especially when there's an 5th column * Use a `separate logger <https://weasyprint.readthedocs.io/en/latest/tutorial.htmllogging>`_ to report the rendering process * Add a ``--debug`` CLI parameter and set debug level for unknown prefixed CSS properties * Define minimal versions of Python and setuptools in setup.cfg Documentation * `796 <https://github.com/Kozea/WeasyPrint/pull/796>`_: Fix a small typo in the tutorial * `792 <https://github.com/Kozea/WeasyPrint/pull/792>`_: Document no alignement character support * `773 <https://github.com/Kozea/WeasyPrint/pull/773>`_: Fix phrasing in Hacking section * `402 <https://github.com/Kozea/WeasyPrint/issues/402>`_: Add a paragraph about fontconfig error * `764 <https://github.com/Kozea/WeasyPrint/pull/764>`_: Fix list of dependencies for Alpine * Fix API documentation of HTML and CSS classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures re-pagination while avoiding endless loops and 'list index out of range'.
Should fix #794
The endless loop can (could) easily be triggered.
The aforesaid 'list index out of range' error happens when resolving page based counters decreases the number of pages.
Though I tried hard I was unable to create an HTML/CSS that per se produced the error, had to tweak the source code to artificailly enforce re-pagination with decreasing pages, hence I'm highly interested to see @guateandrew's real-world document, or at least the CSS?