support CSS Color Level 4 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of level 4 specifications is currently limited to (1) space-seperated arguments with an optional slash-seperated opacity, (2) definition of 'rebeccapurple', (3) percentages and numbers are accepted as opacity value, (4) the hwb() function and (5) hsla()/rgba() being aliases to hsl()/rgb().
|
Thanks for the PR! Let’s work on this topic on a dedicate branch. |
|
Well, CMYK has been postponed to color5. Maybe we should consider following color5 instead of color4. |
This was referenced Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for your work on tinycss2 and WeasyPrint. As i would be very happy to see CMYK support in the future i took a closer look at the different color specifications and their implementation in WeasyPrint.
Coming from Kozea/WeasyPrint#1630 and #47 i started to work on the support of the CSS Color Level 4 specification.
The implementation is currently limited to:
parse_color()accepts now space-seperated arguments with an optional slash-seperated opacityrebeccapurplehwb()functionhsla()/rgba()are aliases tohsl()/rgb()Adding more tests to cover the changes and the level 4 spec would require changes to SimonSapin/css-parsing-tests. I did not start to prepare them yet, but i can open another PR there if this is the way you would like to implement the tests.
I will take a look at some of the other changes listed here and try to implement them as well (e.g. syntactic changes 1 and 2) but i wanted to check-in early to get your feedback before spending more time on this. Let me know what you think and if i should revise some parts of the current implementation.