[FluidDynamicsHydraulicsApplication] Adding new hydraulic utilities; inflow detection and artificial viscosity. #13061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../FluidDynamicsHydraulicsApplication/custom_utilities/hydraulic_fluid_auxiliary_utilities.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
322
to
340
| double neg_nodes = 0.0; | ||
| double pos_nodes=0.0; | ||
| for (auto &r_node : rElement.GetGeometry()) | ||
| { | ||
| double distance = r_node.FastGetSolutionStepValue(DISTANCE); | ||
|
|
||
| if (distance > 0) | ||
| { | ||
| pos_nodes += 1; | ||
| } | ||
| else | ||
| { | ||
| neg_nodes += 1; | ||
| } | ||
| } | ||
| if (neg_nodes > 0 && pos_nodes > 0) | ||
| { | ||
| artificial_viscosity = 0.0; | ||
| } |
There was a problem hiding this comment.
I'd first check if it is whether it is intersected or not. If it is not, you calculate it. If not you skip it.
There was a problem hiding this comment.
Not for this PR but we should at some point do an IsCut tiny function in the utilities (we're doing this in many places).
.../FluidDynamicsHydraulicsApplication/custom_utilities/hydraulic_fluid_auxiliary_utilities.cpp
Outdated
Show resolved
Hide resolved
...ns/FluidDynamicsHydraulicsApplication/custom_utilities/hydraulic_fluid_auxiliary_utilities.h
Outdated
Show resolved
Hide resolved
...ns/FluidDynamicsHydraulicsApplication/custom_utilities/hydraulic_fluid_auxiliary_utilities.h
Outdated
Show resolved
Hide resolved
...ns/FluidDynamicsHydraulicsApplication/custom_utilities/hydraulic_fluid_auxiliary_utilities.h
Outdated
Show resolved
Hide resolved
...cations/FluidDynamicsHydraulicsApplication/tests/test_hydraulic_fluid_auxiliary_utilities.py
Outdated
Show resolved
Hide resolved
…es/hydraulic_fluid_auxiliary_utilities.cpp Co-authored-by: Rubén Zorrilla <[email protected]>
…es/hydraulic_fluid_auxiliary_utilities.cpp Co-authored-by: Rubén Zorrilla <[email protected]>
…es/hydraulic_fluid_auxiliary_utilities.h Co-authored-by: Rubén Zorrilla <[email protected]>
…raulic_fluid_auxiliary_utilities.py Co-authored-by: Rubén Zorrilla <[email protected]>
…es/hydraulic_fluid_auxiliary_utilities.h Co-authored-by: Rubén Zorrilla <[email protected]>
…es/hydraulic_fluid_auxiliary_utilities.h Co-authored-by: Rubén Zorrilla <[email protected]>
rubenzorrilla
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
"In this PR, we add two new methods to the hydraulic utilities:
Reminder for the future: The test for the artificial viscosity calculation is performed in the test of the
TwoFluidNavierStokesFractionalelement within theCalculatemethod, where the artificial viscosity is actually computed.Its application in Python is tested in the solver test. Therefore, adding an extra test to evaluate the method itself within the utility is not considered necessary."
🆕 Changelog