Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Addition of Template Argument TShiftedBoundary #13089

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

NickNick9
Copy link
Contributor

📝 Description

This PR introduces the template argument TShiftedBoundary to BrepTrimmingUtilities.

By default, this template is set to false and is only set to true in the SBM case. It will be enabled from the SBM_Nurbs_Modeler soon.

@NickNick9 NickNick9 requested a review from a team as a code owner February 4, 2025 11:40
@NickNick9
Copy link
Contributor Author

The template was already added in this previous PR already merged: #12717

@rubenzorrilla

Copy link
Contributor

@rickyaristio rickyaristio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, it is okay. I will incorporate it to my other PR (#13080)

@NickNick9 NickNick9 merged commit 93d0e56 into master Feb 4, 2025
11 checks passed
@NickNick9 NickNick9 deleted the PR_small_brep_trimming_utilities branch February 4, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants