Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering of nested elements when sortby = :firstexec #144

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Fix ordering of nested elements when sortby = :firstexec #144

merged 4 commits into from
Mar 7, 2022

Conversation

rikhuijzer
Copy link
Contributor

The ordering of nested elements was reversed when sortby = :firstexec:

julia> using TimerOutputs

julia> to = TimerOutput();

julia> @timeit to "group" begin
           @timeit to "sub1" sleep(0.1)
           @timeit to "sub2" sleep(0.1)
       end

julia> show(to; compact=true, sortby=:firstexec)
 ───────────────────────────────────────────────────
                         Time          Allocations
                   ───────────────   ───────────────
  Total measured:       46.0s            2.29MiB

 Section   ncalls     time    %tot     alloc    %tot
 ───────────────────────────────────────────────────
 group          1    202ms  100.0%   2.55KiB  100.0%
   sub2         1    101ms   50.0%      320B   12.3%
   sub1         1    101ms   50.0%      320B   12.3%
 ───────────────────────────────────────────────────

rikhuijzer and others added 3 commits March 4, 2022 12:58
and change order to insure that it won't happen again
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2022

Codecov Report

Merging #144 (ea547e0) into master (87ba338) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   89.16%   89.26%   +0.10%     
==========================================
  Files           5        5              
  Lines         406      410       +4     
==========================================
+ Hits          362      366       +4     
  Misses         44       44              
Impacted Files Coverage Δ
src/show.jl 96.52% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ba338...ea547e0. Read the comment docs.

@rikhuijzer
Copy link
Contributor Author

On your profile you say "keep pinging" so here we go: @KristofferC

@KristofferC
Copy link
Owner

On your profile you say "keep pinging" so here we go

Great!

@KristofferC KristofferC merged commit 5f869d7 into KristofferC:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants