Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button placement in sell modal and arrow svg #66

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

Pandelissym
Copy link
Contributor

  • Fixed the placement of confirm and previous buttons in sell modal (for items and characters). Wrapped the buttons in wrapper and made the step components a bit smaller so the buttons can fit nicely at the bottom.
  • Removed padding from some arrow icons in the button so they show up properly

closes #64

@Pandelissym Pandelissym changed the title Fix button placement and arrow svg Fix button placement in sell modal and arrow svg Oct 20, 2023
@Pandelissym Pandelissym merged commit 446c61d into develop Oct 20, 2023
@Pandelissym Pandelissym deleted the bug/fix-incorrect-buttons-at-sell branch October 20, 2023 14:21
carlos-kryha added a commit that referenced this pull request Nov 10, 2023
Includes the following work:
- #81 
- #77 
- #71 
- #70 
- #69 
- #67 
- #66 
- #63 (note this update requires a core-eval proposal to take effect)

QA is tracked
[here](https://docs.google.com/spreadsheets/d/1bBJhr73o4W2rd3oYNpK_xET_3m6kNYYbeaDvMKIRQRM/edit?usp=sharing)

---------

Co-authored-by: Privilege Mendes <[email protected]>
Co-authored-by: Axel Verheul <[email protected]>
Co-authored-by: Xabier <[email protected]>
Co-authored-by: Xabier Almazor <[email protected]>
Co-authored-by: Xabier Almazor <[email protected]>
Co-authored-by: Wietze <[email protected]>
Co-authored-by: Xabier Almazor Telek <[email protected]>
Co-authored-by: Nick K <[email protected]>
Co-authored-by: Nick Koster <[email protected]>
Co-authored-by: Pandelis Symeonidis <[email protected]>
Co-authored-by: Pandelis Symeonidis <[email protected]>
Co-authored-by: MangoDream1 <[email protected]>
Co-authored-by: Synthetics <[email protected]>
snthtcs added a commit that referenced this pull request Nov 13, 2023
Includes the following work:
- #81 
- #77 
- #71 
- #70 
- #69 
- #67 
- #66 
- #63 (note this update requires a core-eval proposal to take effect)

QA is tracked
[here](https://docs.google.com/spreadsheets/d/1bBJhr73o4W2rd3oYNpK_xET_3m6kNYYbeaDvMKIRQRM/edit?usp=sharing)

---------

Co-authored-by: Privilege Mendes <[email protected]>
Co-authored-by: Axel Verheul <[email protected]>
Co-authored-by: Xabier Almazor <[email protected]>
Co-authored-by: Xabier Almazor <[email protected]>
Co-authored-by: Wietze <[email protected]>
Co-authored-by: CARLOS TRIGO <[email protected]>
Co-authored-by: Xabier Almazor Telek <[email protected]>
Co-authored-by: Nick K <[email protected]>
Co-authored-by: Nick Koster <[email protected]>
Co-authored-by: carlos-kryha <[email protected]>
Co-authored-by: Pandelis Symeonidis <[email protected]>
Co-authored-by: Pandelis Symeonidis <[email protected]>
Co-authored-by: MangoDream1 <[email protected]>
Co-authored-by: Synthetics <[email protected]>
Co-authored-by: Synthetics <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Low: Previous & Confirm buttons in wrong places on sell character modal
2 participants