Godot 4 issues #11
Merged
Godot 4 issues #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dictionary keys can be any type not just String and dict.keys() can not be upcast from return type of Array to Array[String]. As this function does not return the keys, it's safest and easiest to just remove the String type from unused_info_keys and work with the generics.
Dictionary keys can be any type not just String and dict.keys() can not be upcast from return type of Array to Array[String]. As this function return the keys, it's best check each key and if it is of type String add it to an Array[String] and return it instead of info.keys()
|
Thanks! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues with the new Godot 4 RC's
Issue 1 is resolved with this PR by quoting the warnings in all of @warning_ignore()
Issue 2 has two different resolutions due to different use cases.
addons/gdshell/scripts/gdshell_command_db.gd:get_all_command_names()returns an Array[String] as other commands might rely on this functionality it is best to maintain static typing for the Array.get_all_commands()now iterates over all keys and those which are of type string are added to a new Array[String] which is returned.addons/gdshell/commands/default_commands/gdfetch.gd:construct_outputuses the output frominfo.keys()directly and does not return it, which makes it safe to simply drop the static type fromunused_info_keysand use it as a generic Array.see: https://docs.godotengine.org/en/latest/classes/class_dictionary.html#class-dictionary-method-keys
see: https://www.reddit.com/r/godot/comments/10rqh9g/problem_with_typed_arrays_since_40_beta_17/