Update plugin to work with Godot 4 Beta 13+ #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godot 4 Beta 13 changed the required order of @ICON in relation to @Class. Annotations must appear before the thing they annotate. This corrects the order resolving the issue for GD4 Beta 13, as this is the reverse of the required ordering for GD4 Beta 12 applying this means that the plugin will no longer work for installs of <= GD4 Beta 12, See the following issues for more details: - godotengine/godot#71592 - godotengine/godot-docs#6629 The PR that introduces the change: - godotengine/godot#67774
|
Thanks! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Godot 4 Beta 13 changed the required order of @ICON in relation to @Class. Annotations must appear before the thing they annotate.
This corrects the order resolving the issue for GD4 Beta 13, as this is the reverse of the required ordering for GD4 Beta 12 applying this means that the plugin will no longer work for installs of <= GD4 Beta 12,
See the following issues for more details:
@iconannotation example is outdated godotengine/godot-docs#6629The PR that introduces the change:
class_nameandextendsgodotengine/godot#67774