-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(truesight): add offset when request CoinGecko chart data #1186
Conversation
Auto Deploy Pull RequestYour domain dmm-interface-1186.pr.kyberengineering.io has been created. Notes
|
Auto Deploy Pull RequestYour domain dmm-interface-1186.pr.kyberengineering.io has been revoked because: PR closed. Notes
|
Auto Deploy Pull RequestYour domain dmm-interface-1186.pr.kyberengineering.io has been created. Notes
|
Auto Deploy Pull RequestYour domain dmm-interface-1186.pr.kyberengineering.io has been revoked because: PR closed. Notes
|
const response = await fetch(url, { signal: controller.signal }) | ||
if (Date.now() - latestRequestingTime.current < 2000) { | ||
// Too Many Request | ||
throw new Error('429') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should create a particular error like ToManyRequestError
. the other components will check it to handle it's logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is my trick only, no need for a variable or constant here. If we have one more use-case like this CoinGecko, I'll refactor <3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound's good!
Auto Deploy Pull RequestYour domain dmm-interface-1186.pr.kyberengineering.io has been created. Notes
|
1f8c9d0
to
80cefb5
Compare
Auto Deploy Pull RequestYour domain dmm-interface-1186.pr.kyberengineering.io has been revoked because: PR closed. Notes
|
No description provided.