Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(truesight): add offset when request CoinGecko chart data #1186

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

nhd98z
Copy link
Contributor

@nhd98z nhd98z commented Aug 1, 2022

No description provided.

@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain dmm-interface-1186.pr.kyberengineering.io has been created.

Notes

  • Please wait up to 60s, we need to pull your image.
  • This domain only validity until this PR is closed

@nhd98z nhd98z closed this Aug 1, 2022
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain dmm-interface-1186.pr.kyberengineering.io has been revoked because: PR closed.

Notes

  • Please re-open the PR to re-create this domain!

@nhd98z nhd98z reopened this Aug 1, 2022
@vietanhduong vietanhduong reopened this Aug 1, 2022
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain dmm-interface-1186.pr.kyberengineering.io has been created.

Notes

  • Please wait up to 60s, we need to pull your image.
  • This domain only validity until this PR is closed

@nhd98z nhd98z closed this Aug 1, 2022
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain dmm-interface-1186.pr.kyberengineering.io has been revoked because: PR closed.

Notes

  • Please re-open the PR to re-create this domain!

@nhd98z nhd98z reopened this Aug 1, 2022
const response = await fetch(url, { signal: controller.signal })
if (Date.now() - latestRequestingTime.current < 2000) {
// Too Many Request
throw new Error('429')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should create a particular error like ToManyRequestError. the other components will check it to handle it's logic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is my trick only, no need for a variable or constant here. If we have one more use-case like this CoinGecko, I'll refactor <3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound's good!

@vietanhduong vietanhduong reopened this Aug 1, 2022
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain dmm-interface-1186.pr.kyberengineering.io has been created.

Notes

  • Please wait up to 60s, we need to pull your image.
  • This domain only validity until this PR is closed

@nhd98z nhd98z requested a review from viet-nv August 1, 2022 18:12
@nhd98z nhd98z force-pushed the nguyenhuudungz/truesight-threadhold-request branch from 1f8c9d0 to 80cefb5 Compare August 2, 2022 02:56
@nhd98z nhd98z merged commit 1e46bdb into main Aug 2, 2022
@nhd98z nhd98z deleted the nguyenhuudungz/truesight-threadhold-request branch August 2, 2022 02:57
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain dmm-interface-1186.pr.kyberengineering.io has been revoked because: PR closed.

Notes

  • Please re-open the PR to re-create this domain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants