Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set up tutorial #1192

Merged
merged 39 commits into from
Aug 18, 2022
Merged

set up tutorial #1192

merged 39 commits into from
Aug 18, 2022

Conversation

nguyenhoaidanh
Copy link
Contributor

@nguyenhoaidanh nguyenhoaidanh commented Aug 3, 2022 •
edited
Loading

  • tutorial feature for swap page, click setting => view to see this feature.

image

@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain kyberswap-interface-1192.pr.kyberengineering.io has been created.

Notes

  • Please wait up to 60s, we need to pull your image.
  • This domain only validity until this PR is closed

@nguyenhoaidanh nguyenhoaidanh force-pushed the danh/tutorial-swap branch 6 times, most recently from 81317c5 to f52022a Compare August 10, 2022 03:36
@nguyenhoaidanh nguyenhoaidanh force-pushed the danh/tutorial-swap branch 8 times, most recently from ec67ced to 611c3f9 Compare August 12, 2022 08:18
@nguyenhoaidanh
set up tutorial
effcced 
setup tutorial


set up tutorial


.


.


.


.


.


.


v


.


.


.


.


.


update fontsize


css


update


update css


css


tracking


fix conflict


update tut


merge


.


done custom spotlight


revert package.json


save lockfile


update feedback


fix back btn


update texxt


update title


rm unuse


rebuild


fix: wrong position


fixx: wrong mask target


fix bug f5 show tut


add welcome popup


refactor


refactor


optimize


.


.


,


test eslint


.
@nguyenhoaidanh
popup center
3290e9d
@nguyenhoaidanh
update text
410562f
nguyenhoaidanh
nguyenhoaidanh commented Aug 17, 2022
View reviewed changes
src/components/MenuFlyout/index.tsx
<>
<BrowserView>
<BrowserStyle hasArrow={!!props.hasArrow} customStyle={props.browserCustomStyle}>
if (isMobile)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it fixed this issues https://www.notion.so/kybernetwork/Display-double-Preferences-pop-up-on-iPad-bf5de482cfe5495b886880ee12549129

namgold
namgold reviewed Aug 17, 2022
View reviewed changes
src/components/Settings/index.tsx
Comment on lines +115 to +119
const openTutorialSwapGuide = () => {
setShowTutorialSwapGuide({ show: true, step: 0 })
mixpanelHandler(MIXPANEL_TYPE.TUTORIAL_CLICK_START)
toggle()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useCallback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see any performance problems here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You left many place without useCallback. Oneday one of them have performance issue and someone have to trace back every of your missed. Should add useCallback when posible. Also it help mantainer who read your code know that these function is protected guarantee by useCallback, not having to check if it's have issue or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah no problem at all, Nam should tell a bit more about why

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any update on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... update what? You guys not seeing my message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, that function is used only for onClick.
No need memoize it.
We will memorize it if needed.
The more we use, the more Ram it costs.

@nguyenhoaidanh
Copy link
Contributor Author

updated all suggestions, except the problem we are discussing/confusing. @namgold @hungdoansy

@nguyenhoaidanh nguyenhoaidanh merged commit 84e4a08 into main Aug 18, 2022
@nguyenhoaidanh nguyenhoaidanh deleted the danh/tutorial-swap branch August 18, 2022 07:14
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain kyberswap-interface-1192.pr.kyberengineering.io has been revoked because: PR closed.

Notes

  • Please re-open the PR to re-create this domain!

viet-nv added a commit that referenced this pull request Aug 21, 2022
@viet-nv @nguyenhoaidanh
@nhd98z @Linhhnk @hungdoansy @XiaoYhun @vietanhduong
merge main (#1272)
3db8489 
* fix bug params currency (#1244)

* feat(campaign): enter now go to swap with first eligible token (#1240)

* Change Banner to Polygon Campaign (#1245)

* feat(farm): elastic (#1247)

* fix: staked amount (#1248)

* fix: farm apr (#1249)

* improve: farm ux (#1250)

* Do minor UI improvement (#1246)

* chore: increase gap in TransactionConfirmationModal

* chore: gap in TransactionPopup

* chore: adjust spacing in EnterNow in Campaign page

* chore: add a hyper link to Elastic pools from Farm

* feat(pools): add button to hide pools with low TVL

* refactor(about): update to new style/texts

* fix: apr farm (#1252)

* fix(trending-token-banner): avoid words from breaking at white spaces (#1251)

* Support Brave wallet (#1221)

* feat: support Brave wallet

* refactor(PendingView): simplify props

* simplify checkForBraveBrowser

* chore: update return type of onClickTryAgain

* fix: display Brave wallet identicon

* fix: display wallet options on Brave

In Brave, window.ethereum is not undefined, so a condition fails and there are no wallet options to choose.

* chore(wallet-modal): show hover effect on supported devices only

* fix: display correct wallet name by detecting connector

* fix bug popup noti overlap + import token(#1255)

* fix bug popup noti overlap 

* fix bug import token

* feat: add banner for polygon lido farming (#1256)

* fix: hide ATH pro live chart

* redact wallet address and tx_hash

* switch basic chart to priorities coingecko api

* revert debug

* hide ATH pro live chart

Co-authored-by: nguyenhuudungz <[email protected]>

* fix: ath price chart and reward price (#1258)

* fix(farm): get reward token price from market (#1259)

* feat: tutorial swap page  (#1192)

* refactor(tx-modal): show correct wallet to add token to (#1260)

* chore: update .env.dev (#1262)

* feat: support emergency withdraw (#1263)

* add top banner (#1264)

* update blog link

* fix(farm): mistake in withdraw condition

* fix: update text (#1265)

* fix: can not withdraw on ended tab (#1266)

* feat: switch banner position (#1267)

* fix: can not withdraw on ended tab (#1268)

* Update nginx.conf

* refactor: remove unused constant (#1269)

* fix: revert to public rpc for bsc

Co-authored-by: Nguyễn Hoài Danh <[email protected]>
Co-authored-by: nguyenhuudungz <[email protected]>
Co-authored-by: Kami Ho <[email protected]>
Co-authored-by: Hung Doan <[email protected]>
Co-authored-by: XiaoYhun <[email protected]>
Co-authored-by: Viet-Anh Duong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hungdoansy hungdoansy hungdoansy left review comments

@namgold namgold namgold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nguyenhoaidanh @kyber-ci-bot @hungdoansy @namgold