Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark/Light mode for preloaded html #1194

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Conversation

hungdoansy
Copy link
Contributor

Description

There's currently a flicker when users go the page. It happens because the preloaded HTML is only in Dark mode. This PR contains:

  • Dark/Light mode for the preloaded html
  • Check for dark/light mode right when the html is loaded

@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain kyberswap-interface-1194.pr.kyberengineering.io has been created.

Notes

  • Please wait up to 60s, we need to pull your image.
  • This domain only validity until this PR is closed

@nguyenhoaidanh
Copy link
Contributor

(using dark mode)

  • change to light mode => f5 => it shows dark mode

@hungdoansy
Copy link
Contributor Author

(using dark mode)

  • change to light mode => f5 => it shows dark mode

I'm fixing it. But please wait 1-2s before reloading. It delays 300-400ms before saving data to localStorage

@hungdoansy hungdoansy merged commit bc5b5b3 into main Aug 4, 2022
@hungdoansy hungdoansy deleted the refactor/initial-theme-mode branch August 4, 2022 04:01
@kyber-ci-bot
Copy link

Auto Deploy Pull Request

Your domain kyberswap-interface-1194.pr.kyberengineering.io has been revoked because: PR closed.

Notes

  • Please re-open the PR to re-create this domain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants