Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update build with go 1.14 #510

Merged
merged 2 commits into from
Oct 9, 2020
Merged

update build with go 1.14 #510

merged 2 commits into from
Oct 9, 2020

Conversation

secmask
Copy link
Member

@secmask secmask commented Sep 25, 2020

No description provided.

@secmask secmask changed the base branch from add-margin-trades to develop September 25, 2020 03:05
@secmask secmask requested a review from halink0803 September 25, 2020 03:06
@secmask secmask force-pushed the no-vendor branch 2 times, most recently from 916b3db to ec0f16d Compare September 25, 2020 03:52
halink0803
halink0803 approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@halink0803 halink0803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@secmask secmask added the hacktoberfest-accepted for hacktoberfest time label Oct 9, 2020
@secmask
Copy link
Member Author

secmask commented Oct 9, 2020

I disable unsed check in test file due it has a bug, see golangci/golangci-lint#791

@secmask secmask merged commit 875e102 into develop Oct 9, 2020
@secmask secmask deleted the no-vendor branch October 9, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halink0803 halink0803 halink0803 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted for hacktoberfest time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@secmask @halink0803