Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for different thresholds for OpHitFinder #36

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

asanchezcastillo
Copy link

SBND optical reconstruction requires using individual threshold for each channel. This PR incorporates the required changes which are summarized below:

  • Setting an individual individual threshold for each channel requires carrying the channel number information until the specific reconstruction algorithm. Even thought RunHitFinder takes a raw:OpDetWaveform this is later converted to a pmtana::Waveform_t on the Reconstruct method of PulseRecoManager losing the required information about the channel number. The same happens for the Reconstruct method of PMTPulseRecoBase and the RecoPulse method implemented by the reconstruction algorithm. Fortunately enough, both pmtana::Waveform_t and raw::OpDetWaveform inherit from std::vector<> which to the best of my knowledge makes backwards compatibility given just by changing the object we pass into the former methods.
  • Change the relevant peak finder algorithms to allow for individual threshold setting. The lists of threshold per channel must be passed through a fhicl parameter.

@FNALbuild
Copy link
Contributor

A new Pull Request was created by @asanchezcastillo (Alejandro Sánchez Castillo) for develop.

It involves the following packages:

larana

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larana/OpticalDetector/OpHitFinder/AlgoCFD.cxx \ 
  larana/OpticalDetector/OpHitFinder/AlgoSiPM.cxx \ 
  larana/OpticalDetector/OpHitFinder/AlgoSlidingWindow.cxx

Then commit the changes and push them to your PR branch.

@FNALbuild
Copy link
Contributor

Pull request #36 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again.

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

@knoepfel
Copy link
Member

@asanchezcastillo, do you intend this PR to be in draft state?

@asanchezcastillo
Copy link
Author

@knoepfel I am marking it as ready for review now. Thanks for asking.

@asanchezcastillo asanchezcastillo marked this pull request as ready for review January 27, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Under discussion
Development

Successfully merging this pull request may close these issues.

4 participants