-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for different thresholds for OpHitFinder #36
base: develop
Are you sure you want to change the base?
Conversation
A new Pull Request was created by @asanchezcastillo (Alejandro Sánchez Castillo) for develop. It involves the following packages: larana @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
-code-checks
Then commit the changes and push them to your PR branch. |
Pull request #36 was updated. @LArSoft/level-1-managers, @LArSoft/level-2-managers can you please check and sign again. |
The code-checks are being triggered in jenkins. |
+code-checks |
@asanchezcastillo, do you intend this PR to be in draft state? |
@knoepfel I am marking it as ready for review now. Thanks for asking. |
SBND optical reconstruction requires using individual threshold for each channel. This PR incorporates the required changes which are summarized below:
RunHitFinder
takes araw:OpDetWaveform
this is later converted to apmtana::Waveform_t
on theReconstruct
method ofPulseRecoManager
losing the required information about the channel number. The same happens for theReconstruct
method ofPMTPulseRecoBase
and theRecoPulse
method implemented by the reconstruction algorithm. Fortunately enough, bothpmtana::Waveform_t
andraw::OpDetWaveform
inherit fromstd::vector<>
which to the best of my knowledge makes backwards compatibility given just by changing the object we pass into the former methods.