Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution graphs > Rest should be split into positive and negative sections #886

Closed
marc-vdm opened this issue Nov 27, 2022 · 1 comment · Fixed by #1046
Closed

Contribution graphs > Rest should be split into positive and negative sections #886

marc-vdm opened this issue Nov 27, 2022 · 1 comment · Fixed by #1046
Labels
feature Issues/PRs related to a new feature good first issue Issues to get started with AB development with
Milestone

Comments

@marc-vdm
Copy link
Member

marc-vdm commented Nov 27, 2022

Currently in contribution graphs, AB shows a rest containing a remainder of processes. While this is great, the rest is an aggregate of potentially hundreds or thousands of processes when using common background databases like ecoinvent. Among this 'rest' section, some number of processes will have a negative impact instead of a positive one, though often, the sum of 'rest' will be positive (though lower, as these negative numbers would also be counted, lowering the total sum).

It may be better to split rest up based on the sign of the processes (should be easy in pandas with just a score > 0 selection). This way, AB can show that the remainder has both a positive and a negative impact, which would be more realistic.

Figure below is an example of such a case. I know that in this system there are negative flows for one of the reference flows, but this representation of the contributions only shows a positive 'rest'.
image

For implementation, I think we could keep the same color for both 'rest' flows, just rename them to rest (positive) and rest (negative).

Related issues: #647, #782, #635.

Good place to start is here:

('Rest', ''): C[col, :].sum() - top_contribution[:, 0].sum(),

@marc-vdm marc-vdm added the feature Issues/PRs related to a new feature label Nov 27, 2022
@marc-vdm marc-vdm added the good first issue Issues to get started with AB development with label Sep 22, 2023
marc-vdm added a commit to marc-vdm/activity-browser that referenced this issue Sep 29, 2024
Add:
- CA data: use actual total instead of sum(abs)
- CA data: make distinction between positive and negative rest values (LCA-ActivityBrowser#886)
- CA data: sort based on average of row instead of first column (LCA-ActivityBrowser#887)
- CA table: consistent dropping of empty (rest) rows (LCA-ActivityBrowser#1044)
- CA figure: add marker to show total score when both positive and negative results present (LCA-ActivityBrowser#647)
@marc-vdm marc-vdm mentioned this issue Sep 29, 2024
7 tasks
@marc-vdm marc-vdm added this to the 2.11.0 milestone Sep 30, 2024
Copy link

github-actions bot commented Jan 2, 2025

Note

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.11.0), you can get the new version by updating Activity Browser.

Do you want to be notified of new releases of Activity Browser? Subscribe to our updates mailing list ✉.

🤖 beep boop! I'm a bot and this message was an automated action.
If updating does not make sense for this issue, just ignore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues/PRs related to a new feature good first issue Issues to get started with AB development with
Projects
None yet
1 participant