resolve sankey caching bug

[marc-vdm]

• Bug created in Add caching of Sankey results #1117
• Resolve sankey caching bug #1178

Sankey caching had 2 bugs:

1. Reference flows with same activity name would fall under same cache item, despite potentially being different activities (e.g. different product/location/database).
   • The cache_key is now updated to not be activity name but rather the index number in the reference flow table, this should also suffice for Duplicate reference flows in calculation setups #920
2. Caching did not cache static lca object, meaning it would keep updating when other items were selected (and new graph traversal calculation was started). While the graph was static, items like lca score, reference flow name and unit were updated to the last calculated sankey.
   • This data is now cached as metadata.
   • LCA object is now dropped from the cache as it serves no purpose but did increase size of the cache

Also; some log data was moved to debug, function call was re-ordered and explanation of items in the cache_key was added.

Checklist

• Keep pull requests small so they can be easily reviewed.
• Update the documentation, please follow the numpy style guide.
• Update tests.
• Categorize the PR by setting a good title and adding one of the labels:
  bug, feature, ui, change, documentation, breaking, ci
  as they show up in the changelog.
• Link this PR to related issues by using closing keywords.
• Request a review from another developer.

[coveralls]

coverage: 50.561% (-0.07%) from 50.634%
when pulling 67058d4 on marc-vdm:sankey_caching_bug
into f22833f on LCA-ActivityBrowser:master.

[github-actions]

Note

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.4), you can get the new version by updating Activity Browser.

Do you want to be notified of new releases of Activity Browser? Subscribe to our updates mailing list ✉.

🤖_beep boop! I'm a bot and this message was an automated action._
If updating does not make sense for this issue, just ignore this.