Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation Setup deletion dialogues #1190

Merged

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Jan 8, 2024

User is presented with a warning dialogue when deleting a calculation setup now. A confirmation dialogue is shown when the deletion succeeds. Closes #1186

cs-deletion

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Request a review from another developer.

@mrvisscher mrvisscher added the change PRs related to minor changes to AB label Jan 8, 2024
@mrvisscher mrvisscher requested a review from marc-vdm January 8, 2024 15:00
@coveralls
Copy link

Coverage Status

coverage: 50.963% (+0.3%) from 50.634%
when pulling 7a7ab36 on mrvisscher:cs-deletion-dialogue
into 58a3f05 on LCA-ActivityBrowser:master.

Copy link
Member

@marc-vdm marc-vdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@marc-vdm marc-vdm merged commit d5114f4 into LCA-ActivityBrowser:master Jan 8, 2024
12 checks passed
@marc-vdm marc-vdm added this to the 2.9.4 milestone Jan 8, 2024
Copy link

github-actions bot commented Jan 9, 2024

Note

This issue has been implemented in the new release of Activity Browser 🚀 (version 2.9.4), you can get the new version by updating Activity Browser.

Do you want to be notified of new releases of Activity Browser? Subscribe to our updates mailing list ✉.

🤖_beep boop! I'm a bot and this message was an automated action._
If updating does not make sense for this issue, just ignore this.

@mrvisscher mrvisscher deleted the cs-deletion-dialogue branch January 12, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change PRs related to minor changes to AB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning/confirmation dialog for deleting calculation setups
3 participants