Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple improvements for the scenario import panel #1203

Merged

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Jan 15, 2024

Started out as a bugfix, ended up as a series of quality of life improvements for the scenarios import panel.

  • Changed the scenario import toolbar to look a bit cleaner and to be more intuitive
  • Added some statistics on the bottom so the user can perform some sanity checks on the scenario imports
  • Adding and removing tables is now quicker if the tables are empty
  • You can now actually switch the combination type after you've imported the files
  • added by @marc-vdm: Resolve bug where duplicate flows would crash AB + improve excel/csv scenario exports

Demo

scenario-manager

Related issues

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Jan 15, 2024
@mrvisscher mrvisscher requested a review from marc-vdm January 15, 2024 13:23
@coveralls
Copy link

coveralls commented Jan 15, 2024

Coverage Status

coverage: 50.927% (+0.05%) from 50.879%
when pulling 611f30f on mrvisscher:scenario-deletion-fix
into 6931bad on LCA-ActivityBrowser:master.

@mrvisscher mrvisscher changed the title Deleted scenario's now actually update the scenario dataframe Multiple improvements for the scenario import panel Jan 15, 2024
@mrvisscher mrvisscher marked this pull request as draft January 15, 2024 18:47
@mrvisscher mrvisscher requested a review from bsteubing January 16, 2024 11:23
@mrvisscher mrvisscher marked this pull request as ready for review January 16, 2024 11:23
@mrvisscher mrvisscher added the change PRs related to minor changes to AB label Jan 16, 2024
@marc-vdm marc-vdm added this to the 2.9.5 milestone Jan 24, 2024
@mrvisscher mrvisscher merged commit aebf0d7 into LCA-ActivityBrowser:master Jan 25, 2024
12 checks passed
@mrvisscher mrvisscher deleted the scenario-deletion-fix branch November 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs change PRs related to minor changes to AB
Projects
None yet
3 participants