Always close thread-specific SQLite connections

[mrvisscher]

Fixes an issue where thread-specific SQLite database connections persisted even after said thread was finished, resulting in undeletable projects and segmentation faults. Now, by using run_safely() instead of run() within a reimplemented ABThread, all connections are closed after a thread finishes work.

Probably interesting to you @haasad , as this relates to #1124 and enables us to use Python 3.10 as well.

• Update the CopyDatabaseThread as well

• closes AB crashes upon bw2package import #1078

Checklist

• Keep pull requests small so they can be easily reviewed.
• Update the documentation, please follow the numpy style guide.
• Update tests.
• Categorize the PR by setting a good title and adding one of the labels:
  bug, feature, ui, change, documentation, breaking, ci
  as they show up in the changelog.
• Link this PR to related issues by using closing keywords.
• Add a milestone to the PR for the intended release.
• Request a review from another developer.

[coveralls]

coverage: 50.857% (-0.001%) from 50.858%
when pulling 026ad4b on mrvisscher:thread-database-closer
into ebbc322 on LCA-ActivityBrowser:master.

[haasad]

Hi @mrvisscher,

that's fantastic work! Really happy that you found such an elegant solution for it.

I suggest to also include 3.10 for the tests and the install canary:

• activity-browser/.github/workflows/main.yaml

  Lines 32 to 36 in ebbc322

  	strategy:
  	fail-fast: false
  	matrix:
  	os: [ubuntu-latest, windows-latest, macos-latest]
  	python-version: ['3.8', '3.9', '3.11']

• activity-browser/.github/workflows/install-canary.yaml

  Lines 14 to 18 in ebbc322

  	strategy:
  	fail-fast: false
  	matrix:
  	os: [ubuntu-latest, windows-latest, macos-latest]
  	python-version: ['3.8', '3.9', '3.11']

Other than that LGTM 👍

[mrvisscher]

Thanks for your comments and review @haasad, happy you're happy! 😄