Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed debug panel and StdRedirector #1223

Merged

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Jan 31, 2024

Removes the StdRedirector and consequently debug panel from the AB. The StdRedirector was causing thread instability when they were printing, leading to random crashes without any explanation. This is fixed by removing the redirector, which was necessary for the debug panel to function. Because you can also use your regular console window to read debug messages, it is fine to remove the debug panel in my opinion.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Jan 31, 2024
@mrvisscher mrvisscher added this to the 2.9.6 milestone Jan 31, 2024
@mrvisscher mrvisscher requested a review from marc-vdm January 31, 2024 15:31
@coveralls
Copy link

coveralls commented Jan 31, 2024

Coverage Status

coverage: 50.688% (-0.2%) from 50.857%
when pulling edea1a5 on mrvisscher:remove-debug-panel
into cf3b312 on LCA-ActivityBrowser:master.

Copy link
Member

@marc-vdm marc-vdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge whenever you're ready🧵

@mrvisscher mrvisscher merged commit 30a81c0 into LCA-ActivityBrowser:master Feb 5, 2024
15 checks passed
@mrvisscher mrvisscher deleted the remove-debug-panel branch November 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants