Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install correct version of biosphere when choosing most recent #1234

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Feb 18, 2024

Beryllium issue we were notified of over email

There are multiple problems:

  • AB would not properly take the correct version user selected and would instead use an older version and apply patches to the newest version
  • bw2io has patches, but does apparently not properly update the naming of an unknown amount of flows between unknown versions. The flow from which we found the problem is berillium, which is now called beryllium II in biosphere 3.9. The patches do not update these flownames properly when used. There is an unknown amount of flows that will have similar problems.

It is likely all installs of ecoinvent 3.9 since AB version 2.9.3 have this problem. I don't know why these versions will have installed, as AB usually notifies the user that ecoinvent could not be installed if biosphere flows are unmatched.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR for the intended release.
  • Request a review from another developer.

@marc-vdm marc-vdm added the bug Issues/PRs related to bugs label Feb 18, 2024
@marc-vdm marc-vdm added this to the 2.9.7 milestone Feb 18, 2024
@marc-vdm marc-vdm requested a review from mrvisscher February 18, 2024 09:23
@coveralls
Copy link

coveralls commented Feb 18, 2024

Coverage Status

coverage: 50.681% (-0.007%) from 50.688%
when pulling e289fad on marc-vdm:biosphere_install_fix
into 0955df9 on LCA-ActivityBrowser:master.

Copy link
Collaborator

@mrvisscher mrvisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on the logger, looks good to me otherwise!

@marc-vdm marc-vdm merged commit 7710770 into LCA-ActivityBrowser:master Feb 19, 2024
15 checks passed
@marc-vdm marc-vdm deleted the biosphere_install_fix branch May 14, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants