Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix importing .z7 files directly #1333

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix importing .z7 files directly #1333

merged 1 commit into from
Aug 9, 2024

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Aug 7, 2024 •
edited
Loading

Simple patch to fix the broken .z7 importer.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Aug 7, 2024
@mrvisscher mrvisscher added this to the 2.10.1 milestone Aug 7, 2024
@mrvisscher mrvisscher requested a review from marc-vdm August 7, 2024 09:10
@coveralls
Copy link

Coverage Status

coverage: 54.328% (-0.03%) from 54.361%
when pulling 4b18eee on mrvisscher:database-import-fix
into 7b1217d on LCA-ActivityBrowser:main.

@mrvisscher mrvisscher added the prio:high Issues that are high priority label Aug 8, 2024
@marc-vdm marc-vdm merged commit 60f966e into LCA-ActivityBrowser:main Aug 9, 2024
9 checks passed
@mrvisscher mrvisscher deleted the database-import-fix branch November 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-vdm marc-vdm Awaiting requested review from marc-vdm

Assignees
No one assigned
Labels
bug Issues/PRs related to bugs prio:high Issues that are high priority
Projects
None yet
Milestone
2.10.1
Development

Successfully merging this pull request may close these issues.

Import database Ecoinvent 3.10 import
3 participants
@mrvisscher @coveralls @marc-vdm